Hello Sam, On 15.02.24 23:33, Sam Ravnborg wrote: > Hi Ahmad, > > On Thu, Feb 15, 2024 at 05:29:54PM +0100, Ahmad Fatoum wrote: >> SDRAM setup and SD-Card chainloading support were previously added[1] >> by Sam as well as a WIP patch to enable them for Skov ARM9CPU. >> >> I reworked his final WIP patch and fixed some smaller and bigger issues >> that I ran into. Now barebox can replace at91bootstrap on this platform >> when booted from SD. >> >> What didn't work for me were USB and Ethernet, but these didn't work in >> Linux either when booted with the same device tree. I suspect this to be >> related, but I don't have use for either USB or Ethernet in barebox at >> this time, so I am happy with functional SD and nor flash. >> >> All patches are new ones, except for 11/15, which contains a changelog. >> >> [1]: https://lore.barebox.org/barebox/20220628203849.2785611-12-sam@xxxxxxxxxxxx/ >> > > thanks for picking up this work and finish it. > There we several fixes in the patch-set I would never have found - nice > work! There might still be some dragons in the other drivers, so feel free to tackle them. :-) > All patches are: > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > Except "ARM: at91: skov-arm9cpu: Add SD-Card xload support" - see my > comment about the hardcoded hex-values. > > If the hard-coded hex-values are updated to use the existing defines > this patch is also: > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> Thanks for the review. Will include the tag in v2. Cheers, Ahmad > > Sam > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
