On Wed, Sep 20, 2023 at 01:25:31PM +0200, Marco Felsch wrote: > On 23-09-20, Sascha Hauer wrote: > > regulator_get_voltage() works on struct regulator * which may not always > > be available internally, so add a regulator_get_voltage_internal() and > > use it from regulator_get_voltage(). > > > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > --- > > drivers/regulator/core.c | 52 +++++++++++++++++++++------------------- > > 1 file changed, 27 insertions(+), 25 deletions(-) > > > > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c > > index 8ef5a2372c..5693fa9634 100644 > > --- a/drivers/regulator/core.c > > +++ b/drivers/regulator/core.c > > @@ -121,6 +121,32 @@ static int regulator_set_voltage_internal(struct regulator_dev *rdev, > > return -ENOSYS; > > } > > > > +static int regulator_get_voltage_internal(struct regulator_dev *rdev) > > Can we name this regulator_get_voltage_rdev()? This would align the code > with Linux. Yes. The _internal suffix currently aligns with the other functions we have in barebox, so I'll keep it here in this patch and add a patch to this series changing the names for all functions. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
