On Tue, Jul 11, 2023 at 10:12:39AM +0200, Jules Maselbas wrote: > Hi Sam, > > On Mon, Jul 10, 2023 at 09:47:03PM +0200, Sam Ravnborg wrote: > > Unless there are good reasons that I miss you could squash this with > > patch 8. It looks funny that you add a driver and then delete a lot of > > code because you updated some infrastructure later. > > The reason for this is to be able to revert generic sdhci changes, in case > it breaks other drivers, without completly reverting the dwcmshc driver. > I have only tested the generic changes on the newly added driver. Please resend the series with first the generic sdhci changes and then your driver using it. Should we have to revert the generic sdhci changes then we can still extract the necessary changes to your driver from the v1 series. As a reviewer I don't want to review code that is deleted later in the series. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
