Hi Sam, On Mon, Jul 10, 2023 at 09:47:03PM +0200, Sam Ravnborg wrote: > Unless there are good reasons that I miss you could squash this with > patch 8. It looks funny that you add a driver and then delete a lot of > code because you updated some infrastructure later. The reason for this is to be able to revert generic sdhci changes, in case it breaks other drivers, without completly reverting the dwcmshc driver. I have only tested the generic changes on the newly added driver. Cheers -- Jules