Hi,
On Mon, May 29, 2023 at 10:13:16AM +1000, Marc Reilly wrote:
> This introduces a command to set parameters for a pwm device.
>
> Signed-off-by: Marc Reilly <marc@xxxxxxxxxxxxxxx>
> ---
> commands/Kconfig | 11 ++++
> commands/Makefile | 1 +
> commands/pwm.c | 143 ++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 155 insertions(+)
> create mode 100644 commands/pwm.c
>
> diff --git a/commands/Kconfig b/commands/Kconfig
> index 4d3ff631a8..cc7585bbb2 100644
> --- a/commands/Kconfig
> +++ b/commands/Kconfig
> @@ -1929,6 +1929,17 @@ config CMD_I2C
> -w use word (16 bit) wide access
> -v verbose
>
> +config CMD_PWM
> + bool
> + depends on PWM
> + prompt "PWM commands: pwm_set"
> + help
> + pwm_set - set pwm state
> +
> + Usage: pwm_set [dDPfwis]
> +
> + Controls the pwm values such as period and duty cycle
> +
> config CMD_LED
> bool
> depends on LED
> diff --git a/commands/Makefile b/commands/Makefile
> index 98625a0373..011ae59427 100644
> --- a/commands/Makefile
> +++ b/commands/Makefile
> @@ -69,6 +69,7 @@ obj-$(CONFIG_CMD_GPIO) += gpio.o
> obj-$(CONFIG_CMD_UNCOMPRESS) += uncompress.o
> obj-$(CONFIG_CMD_I2C) += i2c.o
> obj-$(CONFIG_CMD_SPI) += spi.o
> +obj-$(CONFIG_CMD_PWM) += pwm.o
> obj-$(CONFIG_CMD_MIPI_DBI) += mipi_dbi.o
> obj-$(CONFIG_CMD_UBI) += ubi.o
> obj-$(CONFIG_CMD_UBIFORMAT) += ubiformat.o
> diff --git a/commands/pwm.c b/commands/pwm.c
> new file mode 100644
> index 0000000000..a21b918c89
> --- /dev/null
> +++ b/commands/pwm.c
> @@ -0,0 +1,143 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +// SPDX-FileCopyrightText: © 2023 Marc Reilly <marc@xxxxxxxxxxxxxxx>
> +
> +/* pwm - pwm commands */
> +
> +#include <common.h>
> +#include <command.h>
> +#include <errno.h>
> +#include <malloc.h>
> +#include <getopt.h>
> +#include <pwm.h>
> +
> +#define HZ_TO_NANOSECONDS(x) (1000000000UL/(x))
> +
> +static int do_pwm_set(int argc, char *argv[])
> +{
> + struct pwm_device *pwm = NULL;
> + struct pwm_state state;
> + int error = 0;
> + char *devname = NULL;
> + int duty = -1, period = -1;
> + int freq = -1, width = -1;
> + int invert_polarity = -1, stop = -1;
> + int opt;
> +
> + while ((opt = getopt(argc, argv, "d:D:P:f:w:is")) > 0) {
> + switch (opt) {
> + case 'd':
> + devname = optarg;
> + break;
> + case 'D':
> + duty = simple_strtol(optarg, NULL, 0);
> + break;
> + case 'P':
> + period = simple_strtol(optarg, NULL, 0);
> + break;
> + case 'f':
> + freq = simple_strtol(optarg, NULL, 0);
> + break;
> + case 'w':
> + width = simple_strtol(optarg, NULL, 0);
> + break;
> + case 'i':
> + invert_polarity = 1;
> + break;
> + case 's':
> + stop = 1;
> + break;
> + }
> + }
> +
> + if (!devname) {
> + printf(" need to specify a device\n");
> + return COMMAND_ERROR_USAGE;
> + }
> + if ((freq == 0) || (period == 0)) {
> + printf(" period or freqency needs to be non-zero\n");
> + return COMMAND_ERROR_USAGE;
> + }
> + if (width > 100) {
> + printf(" width (%% duty cycle) can't be more than 100%%\n");
> + return COMMAND_ERROR_USAGE;
> + }
> +
> + pwm = pwm_request(devname);
> + if (!pwm) {
> + printf(" pwm device %s not found\n", devname);
> + return -ENODEV;
> + }
> +
> + pwm_get_state(pwm, &state);
> +
> + if ((state.period_ns == 0)
> + && (freq < 0) && (duty < 0) && (period < 0)) {
> + printf(" need to know some timing info; freq or dury/period\n");
typo: s/dury/duty/
> + pwm_free(pwm);
indentation
> + return COMMAND_ERROR_USAGE;
> + }
> +
> + if (invert_polarity >= 0)
> + state.polarity = invert_polarity;
> +
> + /* period */
> + if (freq > 0) {
> + state.p_enable = true;
> + state.period_ns = HZ_TO_NANOSECONDS(freq);
> + if (width < 0) {
> + width = 50;
> + }
> + } else if (period > 0) {
> + state.p_enable = true;
> + state.period_ns = period;
> + }
> +
> + /* duty */
> + if (width >= 0) {
> + pwm_set_relative_duty_cycle(&state, width, 100);
> + } else if (duty >= 0) {
> + if (duty > state.period_ns)
> + printf(" warning: duty_ns is greater than period\n");
> +
> + state.duty_ns = duty;
> + }
> +
> + error = pwm_apply_state(pwm, &state);
> +
> + if (stop > 0) {
> + state.p_enable = false;
> + error = pwm_apply_state(pwm, &state);
> + }
> +
> + pwm_free(pwm);
> +
> + return error;
nit: return 0
> +}
> +
> +BAREBOX_CMD_HELP_START(pwm_set)
> +BAREBOX_CMD_HELP_TEXT("Sets a pwm device parameters.")
> +BAREBOX_CMD_HELP_TEXT(" Specify the device by device name")
> +BAREBOX_CMD_HELP_TEXT(" Timings can either be specified via period + duty (on) duration,")
> +BAREBOX_CMD_HELP_TEXT(" or via frequency. Duty can be given either as a percentage or time.")
> +BAREBOX_CMD_HELP_TEXT(" If a parameter is not specified, the current value will be used")
> +BAREBOX_CMD_HELP_TEXT(" where possible - except when setting frequency, in which case")
> +BAREBOX_CMD_HELP_TEXT(" the 'width' will default to 50%.")
> +BAREBOX_CMD_HELP_TEXT(" Stopping the device does not necessarily set the output to inactive.")
> +BAREBOX_CMD_HELP_TEXT(" To set an output to inactive state, set the duty to 0.")
> +BAREBOX_CMD_HELP_TEXT("Options:")
> +BAREBOX_CMD_HELP_OPT("-d string", "device name (eg 'pwm0')")
> +BAREBOX_CMD_HELP_OPT("-D number", "duty cycle (ns)")
> +BAREBOX_CMD_HELP_OPT("-P number", "period (ns)")
> +BAREBOX_CMD_HELP_OPT("-f number", "frequency (Hz)")
> +BAREBOX_CMD_HELP_OPT("-w number", "duty cycle (%) - the on 'width' of each cycle")
> +BAREBOX_CMD_HELP_OPT("-i\t", "line inverted polarity")
> +BAREBOX_CMD_HELP_OPT("-s\t", "stop (disable) the pwm device")
> +BAREBOX_CMD_HELP_END
> +
> +BAREBOX_CMD_START(pwm_set)
> + .cmd = do_pwm_set,
> + BAREBOX_CMD_DESC("set pwm")
> + BAREBOX_CMD_OPTS("[-dDPfwis]")
> + BAREBOX_CMD_GROUP(CMD_GRP_HWMANIP)
> + BAREBOX_CMD_HELP(cmd_pwm_set_help)
> +BAREBOX_CMD_END
> --
> 2.35.3
>
>
