Hi Michael, Looks good now. I squashed in some things while applying, see below. On Thu, Feb 23, 2023 at 04:36:00PM +0100, Michael Kopfensteiner wrote: > The Variscite DT8MCustomBoard is an eval board for the several Variscite > SOMs of their "DART" product line. This commit adds support for that > baseboard in combination with a DART-MX8M-PLUS SOM. The commit contains > an adapted version of the vendors device tree [1] and the vendors DDR > timings, taken from Variscite's public U-Boot sources [2]. > > Both files have been slightly changed to integrate well with barebox. > > The boardsupport added with this commit does not yet support every > feature of the DT8MCustomBoard. Yet it already supports all basic > necessities to make use of barebox. > > [1] https://github.com/varigit/linux-imx/tree/3f94f35bda827e8aa06beadb10c77358cfb6dad9 > [2] https://github.com/varigit/uboot-imx/tree/7cad2ff68a508c71c572151a85bc786711bab969 > > Signed-off-by: Michael Kopfensteiner <michael.kopfensteiner@xxxxxxxxx> > --- [...] > + gpio-leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpio_leds>; > + > + gp-led1 { > + label = "led1"; > + gpios = <&pca6408_2 7 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + barebox,default-trigger = "heartbeat"; Dropped the barebox,default-trigger property. barebox evaluates the linux,default-trigger as well and as long as both properties don't differ there shouldn't be a need to have both. > +&i2c1 { > + clock-frequency = <400000>; > + pinctrl-names = "default", "gpio"; > + pinctrl-0 = <&pinctrl_i2c1>; > + pinctrl-1 = <&pinctrl_i2c1_gpio>; > + scl-gpios = <&gpio5 14 GPIO_ACTIVE_HIGH>; > + sda-gpios = <&gpio5 15 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + > + pca9450@25 { > + reg = <0x25>; > + compatible = "nxp,pca9450c"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pmic>; > + interrupt-parent = <&gpio1>; > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > + status = "okay"; Dropped this status property, shouldn't be needed. > +&usdhc1 { > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > + pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_wifi>; > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>, <&pinctrl_wifi>; > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>, <&pinctrl_wifi>; > + bus-width = <4>; > + non-removable; > + keep-power-in-suspend; > + status = "okay"; > + > + brcmf: bcrmf@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + laird,regdomain = "US"; Dropped this property. It is not evaluated by mainline Linux and it also doesn't make sense to compile this in statically. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
