On Thu, Jan 26, 2023 at 06:54:06PM +1100, John Watts wrote: > On Wed, Jan 25, 2023 at 08:39:40PM +0100, Marco Felsch wrote: > > Hi John, > > > > this patch should be part of patch1 since without this one you can't > > boot the board, right? > > Yes, but I wanted to do a separate commit so I can document the origin of the > code for the Git history and make it easier to review. Normally you can put everything needed for a new board into a single commit, but splitting it up in two patches as you did gives you the opportunity to add a few lines to the commit message specific to the SDRAM setup. Therefore I think it's good the way you did it. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
