On Wed, Jan 25, 2023 at 08:39:40PM +0100, Marco Felsch wrote:
> Hi John,
>
> this patch should be part of patch1 since without this one you can't
> boot the board, right?
Yes, but I wanted to do a separate commit so I can document the origin of the
code for the Git history and make it easier to review.
If this is inappropriate I'd like to move some of the git description to the
header file instead.
> > enum bootsource bootsrc;
> > @@ -66,6 +74,7 @@ ENTRY_FUNCTION_WITHSTACK(start_imx6q_novena, STACK_TOP, r0, r1, r2)
> > if (!running_from_ram()) {
> > imx6_ungate_all_peripherals();
> > setup_uart();
> > + setup_ram();
>
> Nit: You can also move the setup_ram() into the load_barebox() function.
Hmm. I'm not too sure how I feel about this as the two tasks are unrelated
code-wise. I can change it if it makes things easier.
>
> Regards,
> Marco
John
