Hey Ahmad, On Fri, Jun 10, 2022 at 07:34:49PM +0200, Ahmad Fatoum wrote: > On 10.06.22 18:50, Uwe Kleine-König wrote: > > Callers of *_get_boot_source (e.g. start_atf() of > > nxp-imx8mm-evk or protonic-imx8m) expect src to hold the bootsource > > after return. So assign a value also for the "unknown" case. > > Did you check existing in-tree users to make sure none assigned > a different fallback value and assumed it won't be overwritten > if no bootsource could be found? I checked that now as of 345ef59aa0ea: There are ten users, 3 of them initialize src to BOOTSOURCE_UNKNOWN, the other 7 don't initialize at all. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
