Re: [PATCH] common: reset_source: Remove of_get_reset_source_priority()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 09, 2022 at 10:38:55AM +0300, Alexander Shiyan wrote:
> чт, 9 июн. 2022 г. в 10:32, Sascha Hauer <sha@xxxxxxxxxxxxxx>:
> > On Wed, Jun 08, 2022 at 08:12:44AM +0300, Alexander Shiyan wrote:
> > > of_get_reset_source_priority() has no users,
> > > so it can be safely removed.
> > >
> > > Signed-off-by: Alexander Shiyan <eagle.alexander923@xxxxxxxxx>
> > > ---
> > >  common/reset_source.c  | 20 +++-----------------
> > >  include/reset_source.h |  7 -------
> > >  2 files changed, 3 insertions(+), 24 deletions(-)
> > >
> > > diff --git a/common/reset_source.c b/common/reset_source.c
> > > index 3554cbd0fb..dccb683231 100644
> > > --- a/common/reset_source.c
> > > +++ b/common/reset_source.c
> > > @@ -76,7 +76,9 @@ EXPORT_SYMBOL(reset_source_set_prinst);
> > >
> > >  void reset_source_set_device(struct device_d *dev, enum reset_src_type st)
> > >  {
> > > -     int priority = of_get_reset_source_priority(dev->device_node);
> > > +     unsigned int priority = RESET_SOURCE_DEFAULT_PRIORITY;
> >
> > You said of_get_reset_source_priority() has no users, but here you are
> > removing one.
> 
> Hello.
> 
> Here I meant users outside of the unit :)

Oh, I misread the patch. I thought that it removes the

	of_property_read_u32(node, "reset-source-priority", &priority);

That's not the case, you just placed the line inline.

Ok then, applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux