Hi Ahmad,
On 19. 04. 22 11:16, Ahmad Fatoum wrote:
Hello Andrej,
On 19.04.22 10:39, Andrej Picej wrote:
Since commit a5a4c1d5a3 ("dts: update to v5.13-rc1"), which synced
kernel dts, USB-OTG port on phyFLEX board was set to work only in
peripheral mode. This has to do with phyFLEX baseboard hardware bug,
which prevents correct USB OTG ID pin detection in kernel code.
Unlike linux kernel, barebox doesn't support OTG auto-detection mode via
ID pin. In barebox, user has to select desired USB mode of operation by
setting 'otg.mode' variable. Thus delete 'dr_mode' property from dts to
be able to later select USB OTG operating mode at runtime (either host
or peripheral).
Signed-off-by: Andrej Picej <andrej.picej@xxxxxxxxx>
---
arch/arm/dts/imx6qdl-phytec-pbab01.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/imx6qdl-phytec-pbab01.dtsi b/arch/arm/dts/imx6qdl-phytec-pbab01.dtsi
index 991c7e4fab..36870facdd 100644
--- a/arch/arm/dts/imx6qdl-phytec-pbab01.dtsi
+++ b/arch/arm/dts/imx6qdl-phytec-pbab01.dtsi
@@ -15,6 +15,10 @@
status = "okay";
};
+&usbotg {
+ /delete-property/ dr_mode;
+};
Wouldn't it be better to be explicit and set dr_mode = "otg"?
It doesn't matter here, but some other USB controllers default
to "host" in absence of the property, so setting it to "otg"
will be clearer IMO.
hm...yes, I think you are right. I will fix this and send a v2.
Thanks for your review.
Best regards,
Andrej
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
