On Fri, Aug 13, 2021 at 09:16:48AM +0100, Renaud Barbier wrote: > Set the NAND timings and enable the IFC NAND driver. > > Signed-off-by: Renaud Barbier <renaud.barbier@xxxxxxxxx> > --- > arch/arm/configs/layerscape_defconfig | 11 +++++++ > arch/arm/mach-layerscape/Makefile | 1 + > arch/arm/mach-layerscape/nand.c | 44 +++++++++++++++++++++++++++ > 3 files changed, 56 insertions(+) > create mode 100644 arch/arm/mach-layerscape/nand.c > > diff --git a/arch/arm/configs/layerscape_defconfig b/arch/arm/configs/layerscape_defconfig > index 394cd95c98..fb8e885353 100644 > --- a/arch/arm/configs/layerscape_defconfig > +++ b/arch/arm/configs/layerscape_defconfig > @@ -34,6 +34,10 @@ CONFIG_CMD_GO=y > CONFIG_CMD_RESET=y > CONFIG_CMD_UIMAGE=y > CONFIG_CMD_PARTITION=y > +CONFIG_CMD_MOUNT=y > +CONFIG_CMD_UBI=y > +CONFIG_CMD_UBIFORMAT=y > +CONFIG_CMD_UMOUNT=y > CONFIG_CMD_EXPORT=y > CONFIG_CMD_LOADENV=y > CONFIG_CMD_PRINTENV=y > @@ -69,6 +73,7 @@ CONFIG_CMD_GPIO=y > CONFIG_CMD_I2C=y > CONFIG_CMD_LED=y > CONFIG_CMD_SPI=y > +CONFIG_CMD_NAND=y > CONFIG_CMD_LED_TRIGGER=y > CONFIG_CMD_WD=y > CONFIG_CMD_BAREBOX_UPDATE=y > @@ -85,6 +90,10 @@ CONFIG_DP83867_PHY=y > CONFIG_REALTEK_PHY=y > CONFIG_NET_DSA_MV88E6XXX=y > CONFIG_DRIVER_SPI_FSL_QUADSPI=y > +CONFIG_NAND=y > +CONFIG_NAND_FSL_IFC=y > +CONFIG_MTD_UBI=y > +CONFIG_MTD_UBI_BEB_LIMIT=20 > CONFIG_I2C=y > CONFIG_I2C_IMX=y > CONFIG_I2C_MUX=y > @@ -112,5 +121,7 @@ CONFIG_FS_NFS=y > CONFIG_FS_FAT=y > CONFIG_FS_FAT_WRITE=y > CONFIG_FS_FAT_LFN=y > +CONFIG_FS_UBIFS=y > +CONFIG_FS_UBIFS_COMPRESSION_LZO=y > CONFIG_ZLIB=y > CONFIG_LZO_DECOMPRESS=y > diff --git a/arch/arm/mach-layerscape/Makefile b/arch/arm/mach-layerscape/Makefile > index 854a327c91..99da7b2af0 100644 > --- a/arch/arm/mach-layerscape/Makefile > +++ b/arch/arm/mach-layerscape/Makefile > @@ -6,3 +6,4 @@ obj-pbl-y += boot.o > pbl-y += xload-qspi.o xload.o > obj-$(CONFIG_ARCH_LAYERSCAPE_PPA) += ppa.o ppa-entry.o > obj-$(CONFIG_BOOTM) += pblimage.o > +obj-$(CONFIG_NAND_FSL_IFC) += nand.o > diff --git a/arch/arm/mach-layerscape/nand.c b/arch/arm/mach-layerscape/nand.c > new file mode 100644 > index 0000000000..b36c6b3c46 > --- /dev/null > +++ b/arch/arm/mach-layerscape/nand.c > @@ -0,0 +1,44 @@ > +// SPDX-License-Identifier: GPL-2.0+ > + > +#include <common.h> > +#include <init.h> > +#include <of_address.h> > +#include <linux/fsl_ifc.h> > + > +static int rdb_nand_init(void) > +{ > + struct device_node *np; > + void __iomem *ifc; > + > + if (!of_machine_is_compatible("fsl,ls1046a-rdb")) > + return 0; The code as such is board specific and thus should be in arch/arm/boards/ls1046ardb/. We could make a architecture specific helper function from it which is then called by the board code, but the values written to the registers below are probably very board specific anyway, so with a generic helper function we wouldn't win that much. I moved rdb_nand_init() to the board code while applying. Thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox