On Wed, Jun 09, 2021 at 07:49:13PM +0200, Ahmad Fatoum wrote: > The original code uses regmap for the base address and reg for the > offset to add onto it. The barebox port combines both into one pointer > named reg. In rockchip_pinctrl_set_func(), two different offsets are > used with the same base address. The code erroneously uses > reg (base + offset) in place of base, leading to memory writes into > the wrong registers. Fix this. > > Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > --- > drivers/pinctrl/pinctrl-rockchip.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
