On Fri, Mar 05, 2021 at 10:00:01AM +0100, Uwe Kleine-König wrote: > Instead of just ignoring errors related to getting the vbus regulator > yield at least a warning message. This would have saved me some > debugging time when trying to understand why USB doesn't work without > the right regulator driver enabled. > > Note that machines that don't define a regulator in their device tree > don't issue this warning as regulator_get() returns the dummy regulator > in this case. Note that this warning appears on machines that do define a regulator in their device tree (derived from the kernel upstream dts), but do not actually need it as the regulator was enabled by board code. Arguably that's the problem of these boards and we'll have to look there how we can quiesce the warning. The obvious solution is to implement the missing driver, but we could also add some add_dummy_regulator_for_this_node() function to tell the regulator core that we don't need a specific regulator. First let's see if somebody is annoyed by this message, so applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
