Hello,
On Fri, Mar 05, 2021 at 10:00:01AM +0100, Uwe Kleine-König wrote:
> Instead of just ignoring errors related to getting the vbus regulator
> yield at least a warning message. This would have saved me some
> debugging time when trying to understand why USB doesn't work without
> the right regulator driver enabled.
>
> Note that machines that don't define a regulator in their device tree
> don't issue this warning as regulator_get() returns the dummy regulator
> in this case.
>
> The alternative to error out wasn't accepted because this probably
> creates regressions for regulators that are default-on but without a
> driver in barebox.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> Hello,
>
> (implicit) v1 was sent some time ago with Message-ID:
> <1485d35a-d55b-2440-4852-1737e78f8aa1@xxxxxxxxxxxxxx>. Ahmad suggested
> to use %pe instead of strerror(-ret). This is also the only change
> compared to the first submission.
ping!
Best regards
Uwe
> drivers/usb/imx/chipidea-imx.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/imx/chipidea-imx.c b/drivers/usb/imx/chipidea-imx.c
> index 7b87f302a921..aa27941c8c66 100644
> --- a/drivers/usb/imx/chipidea-imx.c
> +++ b/drivers/usb/imx/chipidea-imx.c
> @@ -256,8 +256,11 @@ static int imx_chipidea_probe(struct device_d *dev)
> }
>
> ci->vbus = regulator_get(dev, "vbus");
> - if (IS_ERR(ci->vbus))
> + if (IS_ERR(ci->vbus)) {
> + dev_warn(dev, "Cannot get vbus regulator: %pe (ignoring)\n",
> + ci->vbus);
> ci->vbus = NULL;
> + }
>
> /*
> * Some devices have more than one clock, in this case they are enabled
> --
> 2.30.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
