Re: [PATCH 1/3] driver: add flag to check if cdev is an mci device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21-05-06 13:59, Ahmad Fatoum wrote:
> 
> 
> On 06.05.21 13:22, Marco Felsch wrote:
> > We need this during mount() to check if the cdev is an mmc/mci device.
> > Later on we add the feature to pass "root=/dev/mmcblk*" as kernel
> > command line.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> > ---
> >  include/driver.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/include/driver.h b/include/driver.h
> > index 0d43b36148..d381aaf78d 100644
> > --- a/include/driver.h
> > +++ b/include/driver.h
> > @@ -496,6 +496,7 @@ int cdev_erase(struct cdev *cdev, loff_t count, loff_t offset);
> >  #define DEVFS_PARTITION_READONLY	(1U << 1)
> >  #define DEVFS_IS_CHARACTER_DEV		(1U << 3)
> >  #define DEVFS_PARTITION_FROM_TABLE	(1U << 4)
> > +#define DEVFS_IS_MCI_DEV		(1U << 5)
> >  
> >  struct cdev *devfs_add_partition(const char *devname, loff_t offset,
> >  		loff_t size, unsigned int flags, const char *name);
> > @@ -509,6 +510,11 @@ static inline void cdev_create_default_automount(struct cdev *cdev)
> >  }
> >  #endif
> >  
> > +static inline bool cdev_is_mci_dev(struct cdev *cdev)
> > +{
> > +	return !!(cdev->flags & DEVFS_IS_MCI_DEV);
> > +}
> 
> Nitpick: cast to bool makes !! superfluous.

Right. I will drop it and add you tag.

> Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> 
> 
> > +
> >  #define DEVFS_PARTITION_APPEND		0
> >  
> >  /**
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux