On Fri, 3 Apr 2020 14:39:27 +0200
Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> wrote:
Hi Ahmad,
You are right! There are several mentions of "endianness"
in current barebox codebase and there is no "endianity" mention.
I'll resend fixed patch soon.
--
Best regards,
Antony Pavlov
> Hi,
>
> On 4/3/20 2:26 PM, Antony Pavlov wrote:
> > The global.endianity variable make it possible
>
> I'd prefer you call it endianness, as that's the term we are
> using elsewhere in barebox.
>
> (unless you've a good reason to introduce a new name,
> if so that should be part of the commit message)
>
> Cheers
> Ahmad
>
> > to determine current endian mode from command
> > line or from script on bi-endian capable system.
> >
> > Signed-off-by: Antony Pavlov <antonynpavlov@xxxxxxxxx>
> > ---
> > common/globalvar.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/common/globalvar.c b/common/globalvar.c
> > index c87f2c9339..7632cb6418 100644
> > --- a/common/globalvar.c
> > +++ b/common/globalvar.c
> > @@ -591,6 +591,8 @@ int globalvar_add_simple_ip(const char *name, IPaddr_t *ip)
> >
> > static int globalvar_init(void)
> > {
> > + const char *endianity;
> > +
> > register_device(&global_device);
> >
> > if (IS_ENABLED(CONFIG_NVVAR))
> > @@ -598,11 +600,19 @@ static int globalvar_init(void)
> >
> > globalvar_add_simple("version", UTS_RELEASE);
> >
> > + if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
> > + endianity = "big";
> > + else
> > + endianity = "little";
> > +
> > + globalvar_add_simple("endianity", endianity);
> > +
> > return 0;
> > }
> > pure_initcall(globalvar_init);
> >
> > BAREBOX_MAGICVAR_NAMED(global_version, global.version, "The barebox version");
> > +BAREBOX_MAGICVAR_NAMED(global_endianity, global.endianity, "The barebox endianity");
> >
> > /**
> > * nvvar_save - save NV variables to persistent environment
> >
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
