Hi Ahmad. On Fri, Mar 06, 2020 at 07:06:26AM +0100, Ahmad Fatoum wrote: > Hi Sam, > > On 3/5/20 9:37 PM, Sam Ravnborg wrote: > >> +#define sama5d2_pmc_enable_periph_clock(clk) \ > >> + at91_pmc_sam9x5_enable_periph_clock(IOMEM(SAMA5D2_BASE_PMC), clk) > > I see no point in this macro. It is not that this can change or will be > > reused by others. > > It makes the code less verbose IMO. Had this been a static inline function I would not have commented on this. But a define is not the way to do this, a define is something you revert to if there is no better wyas to do it. Or so I am teached at least. Anyway - this is becoming pure bikeshed. So if I did not do so then with the cargo cult stuff fixed: Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> Sam > > >> + arm_setup_stack(SAMA5D2_SRAM_BASE + SAMA5D2_SRAM_SIZE - 16); > > This " - 16" is it cargo cult copied from somewhere else? > > Or does it really matter? > > It's cargo cult. Will remove it. I wrote the patch few months ago, Sascha > has since removed other instances of this cargo cult. > > > The rest looked fine to me. > > Thanks for taking the time to look though :-) > > Cheers, > Ahmad > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
