On 1/22/20 8:54 PM, Sascha Hauer wrote: > On Wed, Jan 22, 2020 at 10:39:07AM +0100, Christian Eggers wrote: >> Hi Sascha, >> >> Am Mittwoch, 22. Januar 2020, 09:21:15 CET schrieb Sascha Hauer: >>> Hi Christian, >>> >>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >>>> index 45dd41a2a..34b7fea39 100644 >>>> --- a/drivers/watchdog/Kconfig >>>> +++ b/drivers/watchdog/Kconfig >>>> @@ -4,6 +4,7 @@ config WATCHDOG_IMX_RESET_SOURCE >>>> >>>> menuconfig WATCHDOG >>>> >>>> bool "Watchdog support" >>>> >>>> + select PARAMETER >>> >>> I think this goes into the wrong direction. With CONFIG_PARAMETER >>> enabled we get support for adjusting device parameters from the shell. >>> In environments without shell support parameter support is not needed. >>> For example the watchdog C API doesn't need parameter support and is >>> still usable. >>> >>> The static inline wrappers for dev_add_param_* should return NULL >>> instead of returning ERR_PTR(-ENOSYS). >> >> initially I came to the same result. But previous commits to param.h went in >> the opposite direction: >> >>> 03b59bdb64 ("paramter: The dev_add_param_*() return ERR_PTR(), change >>> no-ops") to return ERR_PTR(-ENOSYS) instead of NULL > > Shouldn't have merged this one as it lacks an explanation why this has > been done. Marc, do you have an idea what the motivation for this patch > was? Sorry, I don't remember.... Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox