Hi Christian, On Tue, Jan 21, 2020 at 12:44:19PM +0100, Christian Eggers wrote: > Without CONFIG_PARAMETER, watchdog_register() will always fail. > > Signed-off-by: Christian Eggers <ceggers@xxxxxxx> > --- > drivers/watchdog/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 45dd41a2a..34b7fea39 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -4,6 +4,7 @@ config WATCHDOG_IMX_RESET_SOURCE > > menuconfig WATCHDOG > bool "Watchdog support" > + select PARAMETER I think this goes into the wrong direction. With CONFIG_PARAMETER enabled we get support for adjusting device parameters from the shell. In environments without shell support parameter support is not needed. For example the watchdog C API doesn't need parameter support and is still usable. The static inline wrappers for dev_add_param_* should return NULL instead of returning ERR_PTR(-ENOSYS). Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
