Re: [RFC PATCH 3/5] mci: add first-stage at91-sdhci driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 06, 2020 at 06:35:38PM +0100, Ahmad Fatoum wrote:
> diff --git a/drivers/mci/sdhci.h b/drivers/mci/sdhci.h
> index a307dc97cd9a..48dc3f36530c 100644
> --- a/drivers/mci/sdhci.h
> +++ b/drivers/mci/sdhci.h
> @@ -38,6 +38,7 @@
>  #define SDHCI_RESPONSE_1					0x14
>  #define SDHCI_RESPONSE_2					0x18
>  #define SDHCI_RESPONSE_3					0x1c
> +#define SDHCI_RESPONSE(i)					(SDHCI_RESPONSE_0 + 4 * (i))
>  #define SDHCI_BUFFER						0x20
>  #define SDHCI_PRESENT_STATE					0x24
>  #define  SDHCI_WRITE_PROTECT			BIT(19)
> @@ -53,6 +54,7 @@
>  #define  SDHCI_CARD_DETECT_SIGNAL_SELECTION	BIT(7)
>  #define  SDHCI_CARD_DETECT_TEST_LEVEL		BIT(6)
>  #define  SDHCI_DATA_WIDTH_8BIT			BIT(5)
> +#define  SDHCI_DMASEL_ADMA32			BIT(4)

Have you verified that all bits you add in this file are valid for the
generic SDHCI controller? There shouldn't be any Atmel specific bits
between them.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux