Re: [PATCH 6/8] ARM: Add generic device tree 2nd stage support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 19, 2019 at 09:26:58AM +0100, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 8/19/19 3:38 PM, Sascha Hauer wrote:
> > +void dt_2nd_aarch64(void *fdt)
> > +{
> > +	unsigned long image_start = (unsigned long)_text + global_variable_offset();
> > +
> > +	arm_setup_stack(image_start);
> 
> Shouldn't we rather place the stack somewhere beyond the end of the barebox image
> instead of assuming that we can access the memory before the start?

Yes, this should be better. barebox is sometimes loaded directly to the
start of SDRAM.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux