Re: [PATCH] ARM: zii-commmon: Fix NULL pointer dereference in do_rdu1_switch_reset()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mi, 2019-10-30 at 09:53 -0700, Andrey Smirnov wrote:
> We need to go to parent's private data to get a pointer to struct
> rave_sp. Fix that.
> 
> Fixes: 493e2ee38f ("ARM: zii-common: add support for switch reset on RDU1")
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>

Urgh, I remember that I fixed the very same bug some time ago. Seems I
lost that fixup before upstreaming...

Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>

> ---
>  arch/arm/boards/zii-common/switch-cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boards/zii-common/switch-cmd.c b/arch/arm/boards/zii-common/switch-cmd.c
> index 30438053a1..2b9c34bfac 100644
> --- a/arch/arm/boards/zii-common/switch-cmd.c
> +++ b/arch/arm/boards/zii-common/switch-cmd.c
> @@ -42,7 +42,7 @@ static int do_rdu2_switch_reset(void)
>  static int do_rdu1_switch_reset(void)
>  {
>  	struct device_d *sp_dev = get_device_by_name("sp");
> -	struct rave_sp *sp = sp_dev->priv;
> +	struct rave_sp *sp = sp_dev->parent->priv;
>  	u8 cmd[] = {
>  		[0] = RAVE_SP_CMD_RESET_ETH_SWITCH,
>  		[1] = 0


_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux