Hi Leif, On Mon, Oct 07, 2019 at 02:15:39PM +0000, Middelschulte, Leif wrote: > Hi, > > setting up GPT on an iMX6, I noticed a small bug subject to > CONFIG_PARTITION_DISK_EFI_GPT_NO_FORCE that leads to unparsed GPTs. > > Background: The iMX supports the mmc user partition as bootmedia > source too. > > Problem: The (additional) filetype check[0] fails, if the given buffer > contains multiple, subsequent file(type)s. The buffer might contain > the beginning of a disk that contains i.e. a Barebox image *and* a > partition table. The function file_detect_type returns a single (first > recognized) type[1]. In my case, it returns the Barebox image type. Looks like the file_detect_type() there should be replaced with file_detect_partition_table(). > > There is a comment about this additional check noting it will be > mandatory as it will be "[..] added to the EFI Spec. per Intel after > v1.02.". Anybody can elaborate on that? > That feedback could help to understand why file_detect_partition_table > is insufficient in this case. What makes you think that file_detect_partition_table() is insufficient? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
