On Mon, Sep 30, 2019 at 11:03 PM Antony Pavlov <antonynpavlov@xxxxxxxxx> wrote:
>
> On Mon, 30 Sep 2019 17:57:18 -0700
> Andrey Smirnov <andrew.smirnov@xxxxxxxxx> wrote:
>
> Hi!
>
> > Linux kernel reports the version of toolchain it was built with as a
> > part of its version string, which can be extremely useful when
> > debugging toolchain related issues. Make Barebox version string, mimic
> > that of Linux to get the same level of information in Barebox.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> > ---
> > common/version.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/common/version.c b/common/version.c
> > index 8b1fd4dbe7..5f57022dac 100644
> > --- a/common/version.c
> > +++ b/common/version.c
> > @@ -3,7 +3,8 @@
> > #include <generated/utsrelease.h>
> >
> > const char version_string[] =
> > - "barebox " UTS_RELEASE " " UTS_VERSION "\n";
> > + "barebox " UTS_RELEASE " (" BAREBOX_COMPILE_BY "@"
> > + BAREBOX_COMPILE_HOST ") (" BAREBOX_COMPILER ") " UTS_VERSION "\n";
> > EXPORT_SYMBOL(version_string);
>
>
> Can we keep COMPILE_BY and COMPILE_HOST in one line (as linux does)?
I don't understand. This line already follows formatting found in
Linux, e. g. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/init/version.c?h=v5.4-rc2#n46
I have no preference how this is going to be formatted, really. Can
you just take this patch reformat it the way you want to see it and
submit it?
Thanks,
Andrey Smirnov
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
