Re: [PATCH] version_string: Add toolchain and build host info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 30 Sep 2019 17:57:18 -0700
Andrey Smirnov <andrew.smirnov@xxxxxxxxx> wrote:

Hi!

> Linux kernel reports the version of toolchain it was built with as a
> part of its version string, which can be extremely useful when
> debugging toolchain related issues. Make Barebox version string, mimic
> that of Linux to get the same level of information in Barebox.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
>  common/version.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/common/version.c b/common/version.c
> index 8b1fd4dbe7..5f57022dac 100644
> --- a/common/version.c
> +++ b/common/version.c
> @@ -3,7 +3,8 @@
>  #include <generated/utsrelease.h>
>  
>  const char version_string[] =
> -	"barebox " UTS_RELEASE " " UTS_VERSION "\n";
> +	"barebox " UTS_RELEASE " (" BAREBOX_COMPILE_BY "@"
> +	BAREBOX_COMPILE_HOST ") (" BAREBOX_COMPILER ") " UTS_VERSION "\n";
>  EXPORT_SYMBOL(version_string);


Can we keep COMPILE_BY and COMPILE_HOST in one line (as linux does)?
E.g.
--- a/common/version.c
+++ b/common/version.c
@@ -3,7 +3,11 @@
 #include <generated/utsrelease.h>
 
 const char version_string[] =
-       "barebox " UTS_RELEASE " " UTS_VERSION "\n";
+       "barebox " UTS_RELEASE
+       " (" BAREBOX_COMPILE_BY "@" BAREBOX_COMPILE_HOST ") "
+       "(" BAREBOX_COMPILER ") "
+       UTS_VERSION "\n";
+
 EXPORT_SYMBOL(version_string);
 
 const char release_string[] =





>  
>  const char release_string[] =
> -- 
> 2.21.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox


-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux