Hi Uwe, On Tue, Sep 17, 2019 at 10:01:26AM +0200, Uwe Kleine-König wrote: > Hello Stefan, > > On Sun, Sep 15, 2019 at 09:31:14PM +0200, Stefan Lengfeld wrote: > > On my machine 'make docs' fails with > > > > Traceback (most recent call last): > > File "/home/stc/git/barebox/Documentation/gen_commands.py", line 156, in <module> > > parse_c(source) > > File "/home/stc/git/barebox/Documentation/gen_commands.py", line 34, in parse_c > > for line in file(name, 'r'): > > NameError: name 'file' is not defined > > > > because /usr/bin/python points to python3 instead of python2. Fix this > > by including the language version in the shebang of the script. > > It would be much preferable to convert this code to Python3. I looked > into that and it wasn't that hard to even make it compatible to both > Python 2 and Python 3. (One downside is that Python 3 is more picky > about file encodings, so I have to insert a patch that converts the few > latin1 file left in the tree to utf-8 first. But as this is a good thing > on its own (IMHO) that's not too bad.) > > Find the two patches in reply to this mail. Indeed, converting the script to support Python 2 and 3 at the same time is the better fix. Tested-By: Stefan Lengfeld <contact@xxxxxxxxxxxxxxx> Kind regards, Stefan _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
