Re: [PATCH] docs: add python version in shebang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Stefan,

On Sun, Sep 15, 2019 at 09:31:14PM +0200, Stefan Lengfeld wrote:
> On my machine 'make docs' fails with
> 
>     Traceback (most recent call last):
>       File "/home/stc/git/barebox/Documentation/gen_commands.py", line 156, in <module>
>         parse_c(source)
>       File "/home/stc/git/barebox/Documentation/gen_commands.py", line 34, in parse_c
>         for line in file(name, 'r'):
>     NameError: name 'file' is not defined
> 
> because /usr/bin/python points to python3 instead of python2. Fix this
> by including the language version in the shebang of the script.

It would be much preferable to convert this code to Python3. I looked
into that and it wasn't that hard to even make it compatible to both
Python 2 and Python 3. (One downside is that Python 3 is more picky
about file encodings, so I have to insert a patch that converts the few
latin1 file left in the tree to utf-8 first. But as this is a good thing
on its own (IMHO) that's not too bad.)

Find the two patches in reply to this mail.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux