Hi, comments as always below. On Fri, 2019-05-24 at 13:32 +0200, Maik Otto wrote: > Insert in the Kconfig the selection for the build type signed, usb > signed, > encrypted/signed and unsigned as basic for the replacement the > static > variant in the Makefile.imx > > Signed-off-by: Maik Otto <m.otto@xxxxxxxxx> > --- > arch/arm/mach-imx/Kconfig | 25 +++++++++++++++++++++++++ > images/Makefile.imx | 1 + > 2 files changed, 26 insertions(+) > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > index 71d37ce..fdb4239 100644 > --- a/arch/arm/mach-imx/Kconfig > +++ b/arch/arm/mach-imx/Kconfig > @@ -845,6 +845,24 @@ config HABV4_IMG_CRT_PEM > > endif > > +if HABV4 > + > +choice > + prompt "Select Building Signed/Encrypted Bootloader" > + > +config HABV4_IMAGE_SIGNED > + bool "build signed images" > + > +config HABV4_IMAGE_SIGNED_USB > + bool "build signed images and signed USB images" > + > +config HABV4_IMAGE_SIGNED_ENCRYPTED > + bool "build signed encrypted images" > + > +endchoice > + > +endif This is a regression in contrast with the current system. The current systems allows a build of all three images (albeit with a modification to Makefile.imx), and imo this should be a selection rather than a choice. Regards, Rouven Czerwinski -- Pengutronix e.K. | | Industrial Linux Solutions | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
