On Mon, Mar 18, 2019 at 11:31:48AM +0100, Roland Hieber wrote: > On Mon, Mar 18, 2019 at 10:14:48AM +0100, Sascha Hauer wrote: > > barebox_arm_reset_vector() is a global function but we never provided a > > prototype anywhere. The prototypes differ for the different boards, so > > to provide a common prototype we must harmonize them. > > > > void barebox_arm_reset_vector(uint32_t r0, uint32_t r1, uint32_t r2) > > > > Should be suitable for all boards. > > > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > --- > > [...] > > > diff --git a/arch/arm/mach-imx/cpu_init.c b/arch/arm/mach-imx/cpu_init.c > > index f0d009dfd2..471ef0cfd5 100644 > > --- a/arch/arm/mach-imx/cpu_init.c > > +++ b/arch/arm/mach-imx/cpu_init.c > > @@ -12,6 +12,7 @@ > > * GNU General Public License for more details. > > */ > > > > +#include <common.h> > > Was this intentional? The commit message doesn't say anything about it, > and it is the only such change in the commit. Yes, that is intentional. With the change of the prototype we need the typedef for uint32_t which is undefined without previous inclusion of linux/types.h (or common.h) Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
