Re: [PATCH 05/11] ARM: boards: Harmonize barebox_arm_reset_vector() prototype

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 18, 2019 at 10:14:48AM +0100, Sascha Hauer wrote:
> barebox_arm_reset_vector() is a global function but we never provided a
> prototype anywhere. The prototypes differ for the different boards, so
> to provide a common prototype we must harmonize them.
> 
> void barebox_arm_reset_vector(uint32_t r0, uint32_t r1, uint32_t r2)
> 
> Should be suitable for all boards.
> 
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> ---

[...]

> diff --git a/arch/arm/mach-imx/cpu_init.c b/arch/arm/mach-imx/cpu_init.c
> index f0d009dfd2..471ef0cfd5 100644
> --- a/arch/arm/mach-imx/cpu_init.c
> +++ b/arch/arm/mach-imx/cpu_init.c
> @@ -12,6 +12,7 @@
>   * GNU General Public License for more details.
>   */
>  
> +#include <common.h>

Was this intentional? The commit message doesn't say anything about it,
and it is the only such change in the commit.

 - Roland

>  #include <asm/barebox-arm-head.h>
>  #include <asm/errata.h>
>  #include <linux/types.h>
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Roland Hieber                     | r.hieber@xxxxxxxxxxxxxx     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux