On Tue, Mar 12, 2019 at 08:31:46PM -0700, Andrey Smirnov wrote: > We need to make sure that CNTFRQ is initialized before corresponding > clocksource driver tries to use it, otherwise we'll end up crashing > due to division by zero. > > We can't convert imx7_timer_init() to be an initcall since it is an > i.MX7 specific task, but CPU type information won't be availible until > after imx_init() gets executed at postcore_initcall() level. To solve > this move all of the necessary code to be a part of > imx7_cpu_lowlevel_init(). > > Note, that original code both hardcoded frequency value to 8MHz as > well as tried to write it to the first element of the frequency mode > table which appears to be read-only on i.MX7. So while we are at it, > simplify the code by adding set_cntfrq() implementation for ARMv7 and > copy the code we already using for i.MX8MQ. > > Fixes: dece70752 ("clocksource: Enable architected timer support for CPU_V7") > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > --- > arch/arm/include/asm/system.h | 5 +++++ > arch/arm/mach-imx/cpu_init.c | 13 +++++++++++++ > arch/arm/mach-imx/imx7.c | 35 ----------------------------------- > 3 files changed, 18 insertions(+), 35 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox