On Wed, Feb 27, 2019 at 3:10 AM Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: > > Am Dienstag, den 26.02.2019, 19:16 -0800 schrieb Andrey Smirnov: > > Add nodes for exposed USB ports as well as USB hub connected to one of > > them. > > > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > > --- > > arch/arm/dts/imx8mq-zii-ultra-rmb3.dts | 4 +++ > > arch/arm/dts/imx8mq-zii-ultra.dtsi | 34 ++++++++++++++++++++++++++ > > 2 files changed, 38 insertions(+) > > > > diff --git a/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts b/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts > > index b2b3a560b..78280029b 100644 > > --- a/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts > > +++ b/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts > > @@ -37,3 +37,7 @@ > > > >; > > > }; > > }; > > + > > +&usb_hub { > > + port-swap=<0x01>; > > This is wrong. With the upstream driver/binding this should be: > swap-dx-lanes = <0>; > Ugh, missed this one, will send a fixup. > > +}; > > diff --git a/arch/arm/dts/imx8mq-zii-ultra.dtsi b/arch/arm/dts/imx8mq-zii-ultra.dtsi > > index 83d57916e..d46a26d81 100644 > > --- a/arch/arm/dts/imx8mq-zii-ultra.dtsi > > +++ b/arch/arm/dts/imx8mq-zii-ultra.dtsi > > @@ -226,6 +226,16 @@ > > > pinctrl-names = "default"; > > > pinctrl-0 = <&pinctrl_i2c3>; > > > status = "okay"; > > + > > > > + usb_hub: usb2513b@2c { > > > + compatible = "microchip,usb2513b"; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_usb2513b>; > > > + #address-cells=<1>; > > + #size-cells=<1>; > > Why the address-cells and size-cells here? I don't see why this is > needed. > Probably just a leftover from vendor tree where this node has children. Will fix. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox