Re: [PATCH 7/7] ARM: imx8mq-zii-ultra: Add USB related nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, den 26.02.2019, 19:16 -0800 schrieb Andrey Smirnov:
> Add nodes for exposed USB ports as well as USB hub connected to one of
> them.
> 
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
>  arch/arm/dts/imx8mq-zii-ultra-rmb3.dts |  4 +++
>  arch/arm/dts/imx8mq-zii-ultra.dtsi     | 34 ++++++++++++++++++++++++++
>  2 files changed, 38 insertions(+)
> 
> diff --git a/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts b/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts
> index b2b3a560b..78280029b 100644
> --- a/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts
> +++ b/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts
> @@ -37,3 +37,7 @@
> >  		>;
> >  	};
>  };
> +
> +&usb_hub {
> +	port-swap=<0x01>;

This is wrong. With the upstream driver/binding this should be:
swap-dx-lanes = <0>;

> +};
> diff --git a/arch/arm/dts/imx8mq-zii-ultra.dtsi b/arch/arm/dts/imx8mq-zii-ultra.dtsi
> index 83d57916e..d46a26d81 100644
> --- a/arch/arm/dts/imx8mq-zii-ultra.dtsi
> +++ b/arch/arm/dts/imx8mq-zii-ultra.dtsi
> @@ -226,6 +226,16 @@
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_i2c3>;
> >  	status = "okay";
> +
> > > +	usb_hub: usb2513b@2c {
> > +		compatible = "microchip,usb2513b";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_usb2513b>;
> > +		#address-cells=<1>;
> +		#size-cells=<1>;

Why the address-cells and size-cells here? I don't see why this is
needed.

Regards,
Lucas

> +		reg = <0x2c>;
> > +		reset-gpios = <&gpio3 25 GPIO_ACTIVE_LOW>;
> > +	};
>  };
>  
>  &i2c4 {
> @@ -312,6 +322,24 @@
> >  	};
>  };
>  
> +&usb_dwc3_0 {
> > +	status = "okay";
> > +	dr_mode = "host";
> +};
> +
> +&usb3_phy0 {
> > +	status = "okay";
> +};
> +
> +&usb_dwc3_1 {
> > +	status = "okay";
> > +	dr_mode = "host";
> +};
> +
> +&usb3_phy1 {
> > +	status = "okay";
> +};
> +
>  &usdhc1 {
> >  	pinctrl-names = "default", "state_100mhz", "state_200mhz";
> >  	pinctrl-0 = <&pinctrl_usdhc1>;
> @@ -426,6 +454,12 @@
> >  		>;
> >  	};
>  
> > +	pinctrl_usb2513b: usb2513bgrp {
> > +		fsl,pins = <
> > +			MX8MQ_IOMUXC_SAI5_MCLK_GPIO3_IO25    0x41
> > +		>;
> > +	};
> +
> >  	pinctrl_usdhc1: usdhc1grp {
> >  		fsl,pins = <
> > >  			MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK			0x83

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux