Re: [PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Sascha,

On 20/2/19 08:55, Sascha Hauer wrote:
> On Tue, Feb 19, 2019 at 10:10:02PM +0100, Ahmad Fatoum wrote:
>> Hello Sam,
>>
>> On 19/2/19 21:42, Sam Ravnborg wrote:
>>> Hi Ahmad.
>>>
>>> On Tue, Feb 19, 2019 at 01:06:10PM +0100, Ahmad Fatoum wrote:
>>>> This is in line with other platforms such as i.MX, which allow
>>>> specifying a debug port. As we can't use port indices because
>>>> the UARTs aren't mapped consecutively, allow specifying a hex
>>>> base at configuration time.
>>>>
>>>> A side effect of this patch is that sama5d4's HAVE_AT91_DBGU2
>>>> is now honored as well. Previously anything besides DBGU0
>>>> defaulted to DBGU1.
>>>
>>> This approch hardcoded the DBGU address based on the configuration.
>>> Can you somehow come up with something that is run-time configured?
>>
>> I think it should remain build-time configurable, to account for cases
>> such as when the designated debug port isn't usable for whatever reason
>> (e.g. its exposed via a USB-to-UART bridge and you want to use a proper
>> UART, because you hate that the disconnection on power cycle..).
> 
> Something like this should work:
> 
> config AT91_DEBUG_DEFAULT_BASE
> 	hex
> 	default 0xfffff200 if AT91_DBGU_AT91RM9200
> 	default 0xffffee00 if AT91_DBGU_AT91SAM9263
> 	default 0xfc069000 if AT91_DBGU_AT91SAMA5D4
> 
> choice
> 	prompt "Choose Lowlevel debug UART"
> 
> config AT91_DBGU_AT91RM9200
> 	bool "AT91RM9200, AT91SAM926[01], AT91SAM9x5, AT91SAM9N12"
> config AT91_DBGU_AT91SAM9263
> 	bool "AT91SAM9263, AT91SAM9G45, ARCH_SAMA5D3"
> config AT91_DBGU_AT91SAMA5D4
> 	bool "AT91SAMA5D4"
> endchoice
> 
> This lets you choose the right one if multiple SoCs are enabled during
> build. Of course it only works if you choose the correct one for the SoC
> you are running on later.

I would like to keep it configurable, i.e. the user can choose which
UART port to choose. Is this ok? 

> 
> Sascha
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux