Re: [PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ahmad.

> I think it should remain build-time configurable, to account for cases
> such as when the designated debug port isn't usable for whatever reason
> (e.g. its exposed via a USB-to-UART bridge and you want to use a proper
> UART, because you hate that the disconnection on power cycle..).
> 
> The hard coded values are just some often applicable defaults.
> 
> > So we can continue towards the goal to have multi-image support
> > for at91.
> > The current approch will limit us to a single type of SOC -
> > and we may try to combine more than one SOC in the same multi-iamge
> > sometime in the future.
> > 
> > Maybe each board have to call an debug_ll_init(address) function or similar.
> > If not called we can use the default which is the common address
> > for most at91 SOCs.
> 
> It's a low level debug option, my understanding is that you only enable it
> when one specific entry point fails to load on your board and you need some early
> output to start debugging.
> It shouldn't be kept on by default. Indeed only 6 defconfigs out of 126 ARM defconfigs
> turn it on. (One of them my fresh microchip_ksz9477_evb_bootstrap_mmc_defconfig, oops..)
I follow you here and see your point.
Lets keep is as you did it.

	Sam

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux