On 18. 02. 19 09:42, Sascha Hauer wrote:
On Thu, Feb 14, 2019 at 02:24:27PM +0100, Tomaz Solc wrote:
pinctrl driver needs to be initialized before mci driver or the pinctrl
device tree properties in the mci node are ignored. Since mci is already
initialized by the coredevice_initcall(), changing the link order is currently
the only way to ensure that.
The same applies most other subsystems, so instead of moving mci down I
would rather suggest to move pinctrl up.
The other thing is: Why does the bcm2835 mci driver use coredevice_initcall()
at all? Normally it should be a device_initcall(). Since the
coredevice_initcall() goes back to the initial commit of the driver I
suspect there is no special reason for that decision and so I think we
should just change to device_initcall().
Good point. I checked other drivers under mci/ and it seems they all use
device_initcall(). I thought that storage must come before
fs_initcall(), but that is not actually the case. As far as I can see,
nothing breaks by moving mci-bcm2835 to device_initcall(). I'll update
the patch.
Best regards
Tomaž
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
