Re: [PATCH 5/7] mci: move after pinctrl in link order.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 14, 2019 at 02:24:27PM +0100, Tomaz Solc wrote:
> pinctrl driver needs to be initialized before mci driver or the pinctrl
> device tree properties in the mci node are ignored. Since mci is already
> initialized by the coredevice_initcall(), changing the link order is currently
> the only way to ensure that.

The same applies most other subsystems, so instead of moving mci down I
would rather suggest to move pinctrl up.

The other thing is: Why does the bcm2835 mci driver use coredevice_initcall()
at all? Normally it should be a device_initcall(). Since the
coredevice_initcall() goes back to the initial commit of the driver I
suspect there is no special reason for that decision and so I think we
should just change to device_initcall().

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux