Re: [PATCH] ARM: phyCORE-i.MX8M SOM support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

On Wed, Feb 06, 2019 at 07:41:22PM +0100, Christian Hemp wrote:
> The phyCORE-i.MX8M aka PCL-066 is a SoM containing a i.MX8M SoC.
> 
> phyCORE-i.MX8M:
>  - 1GB LPDDR4 RAM
>  - eMMC
>  - microSD
>  - Ethernet
> > +
> diff --git a/arch/arm/dts/imx8mq-phytec-phycore-som.dts b/arch/arm/dts/imx8mq-phytec-phycore-som.dts
> new file mode 100644
> index 000000000..7b566e32b
> --- /dev/null
> +++ b/arch/arm/dts/imx8mq-phytec-phycore-som.dts
> @@ -0,0 +1,328 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2018 Christian Hemp <christian.hemp@xxxxxxxxx>
> + */
> +
> +/dts-v1/;
> +
> +#include <arm64/freescale/imx8mq.dtsi>
> +#include <dt-bindings/net/ti-dp83867.h>
> +#include "imx8mq.dtsi"
> +#include "imx8mq-ddrc.dtsi"
> +
> +/ {
> +	model = "Phytec phyCORE-i.MX8";
> +	compatible = "phytec,imx8mq-pcl066", "fsl,imx8mq";
> +
> +	chosen {
> +		stdout-path = &uart1;
> +
> +		environment-emmc {
> +			compatible = "barebox,environment";
> +			device-path = &usdhc1, "partname:barebox-environment";
> +			status = "disabled";
> +		};
> +
> +		environment-sd {
> +			compatible = "barebox,environment";
> +			device-path = &usdhc2, "partname:barebox-environment";
> +			status = "disabled";
> +		};

I pretty much prefer adding a phandle to the partition itself rather
than using this "partname:" mechanism.

Otherwise the patch looks good to me.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux