Hello Sam, On 16/1/19 19:24, Sam Ravnborg wrote: > Hi Ahmad. > > On Wed, Jan 16, 2019 at 06:45:51PM +0100, Ahmad Fatoum wrote: >> Only at91sam9g45_reset.S and the header itself actually use >> any of the macros defined within. >> >> Instead of adding missing definitions and adapting the incoming DDRAMC >> initialization code from at91bootstrap, just include the at91_ddrsdrc.h >> header wholesale. > > This seems to go in the opposite direction > of what we did in for example this commit: > eaa7fcf934826d519f532227c304c09a62cfe685 ("ARM: at91: Add SoC namespace to matrix defines") > > It adds a lot of defines that are not prefixed with SOC names, > so asking for conflicts. You refer to the {HDDRSDRC2,MPDDRC}_* ones? I'll prefix those in v2. > > Also the patch was a little hard to follow with several types of > changes in one patch. > (Adding files, replacing header files, deleting files) Will split it for v2. > > Sam > Thanks Ahmad -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox