Hi Ahmad. On Wed, Jan 16, 2019 at 06:45:51PM +0100, Ahmad Fatoum wrote: > Only at91sam9g45_reset.S and the header itself actually use > any of the macros defined within. > > Instead of adding missing definitions and adapting the incoming DDRAMC > initialization code from at91bootstrap, just include the at91_ddrsdrc.h > header wholesale. This seems to go in the opposite direction of what we did in for example this commit: eaa7fcf934826d519f532227c304c09a62cfe685 ("ARM: at91: Add SoC namespace to matrix defines") It adds a lot of defines that are not prefixed with SOC names, so asking for conflicts. Also the patch was a little hard to follow with several types of changes in one patch. (Adding files, replacing header files, deleting files) Sam _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox