On Mon, Oct 29, 2018 at 12:43:29PM +0100, Ladislav Michl wrote: > On Mon, Oct 29, 2018 at 11:07:02AM +0100, Ladislav Michl wrote: > > On Sun, Oct 28, 2018 at 10:22:13PM +0100, Ladislav Michl wrote: > > > Linux commit b32843b772db adapted for Barebox: > > > > Hmm, there's something fishy with markgood functions (trying different board). > > Debugging now... > > > > > nand_base.c shouldn't have to know the implementation details of > > > nand_bbt's in-memory BBT. Specifically, nand_base shouldn't perform the > > > bit masking and shifting to isolate a BBT entry. > > > > > > Instead, just move some of the BBT code into a new nand_markbad_bbt() > > > interface. This interface allows external users (i.e., nand_base) to > > > mark a single block as bad in the BBT. Then nand_bbt will take care of > > > modifying the in-memory BBT and updating the flash-based BBT (if > > > applicable). > > Two bugs spotted: > 1) we need to select chip again after erase > 2) Linux cares only about marking block bad in BBT while Barebox supports > also unmarking it. Thus we need a bit more complicated version of > bbt_mark_entry. > > Incremental patch bellow. Please let me know if there are another issues > with this serie, I'll squash it for v2. I had a look over the series, but it's very hard to do a proper review without spending a lot of time. I guess I just have to believe that these are Linux commits and thus are good and valuable for barebox aswell ;) Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
