On Mon, Aug 20, 2018 at 11:26:00PM -0700, Andrey Smirnov wrote: > Returning !bbu_find_handler() from barebox_update_handler_exists() > would return the opposite result from what the name of that funciton > implies. Drop the "!" to make it behave as expected. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > --- > common/bbu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/bbu.c b/common/bbu.c > index 11e44f4a7..69ccac68a 100644 > --- a/common/bbu.c > +++ b/common/bbu.c > @@ -151,7 +151,7 @@ bool barebox_update_handler_exists(struct bbu_data *data) > if (!data->handler_name) > return false; > > - return !bbu_find_handler(data->handler_name); > + return bbu_find_handler(data->handler_name); As bbu_find_handler() returns a pointer maybe better '!!' or bbu_find_handler() != NULL? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
