On Sun, May 27, 2018 at 12:28 AM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > Hi Andrey > > On Sat, May 26, 2018 at 01:44:04PM -0700, Andrey Smirnov wrote: >> From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> >> >> the ESDHC controller is a 32bit device, so can do DMA only on the >> lower 32bit. Fix the compiler warning about casting a pointer to integer >> of different size on aarch64 by casting to unsigned long first. Error >> out if the destination does not fit into 32bit though. >> >> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> >> --- > Nitpicking... > > In the kernel the "Signed-off-by:" lines shall document the path of the patch > towards the kernel. So every time a patch passes a person, this person is supposed > to add a "Signed-off" to explicit say that: Hmm, that's not really how I interpret "11) Sign your work - the Developer's Certificate of Origin". Not saying that my interpretation is right, but I added Signed-off-by's with "To improve tracking of who did what" goal in mind. > " > The contribution was provided directly to me by some other > person who certified (a), (b) or (c) and I have not modified > it. > " Yeah, that's item (c), which I can't really certify since there was no direct communication involved and I just got the patches that Sascha previously posted on the mailing list ([v1] in the cover letter). Items (a) and (b) don't really seem applicable to me, since they all involve me being responsible for writing some portion of the patch. Anyway, it is trivial for me to add those, and I am more than happy to do it, but since I am lazy, I'll wait for Sascha's say-so for that. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
