Hi Andrey
On Sat, May 26, 2018 at 01:44:04PM -0700, Andrey Smirnov wrote:
> From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
>
> the ESDHC controller is a 32bit device, so can do DMA only on the
> lower 32bit. Fix the compiler warning about casting a pointer to integer
> of different size on aarch64 by casting to unsigned long first. Error
> out if the destination does not fit into 32bit though.
>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> ---
Nitpicking...
In the kernel the "Signed-off-by:" lines shall document the path of the patch
towards the kernel. So every time a patch passes a person, this person is supposed
to add a "Signed-off" to explicit say that:
"
The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
"
>From Documentation/process/submitting-patches.rst
So in other words - I had expected to see:
Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Signed-off-by: Andrey Smirnov <...>
And then, when Sasha apply the patch he adds a third "Signed-off".
I dunno how strong the rules are followed for barebox,
and you can also find many examples in the kernel where
the rules are not followed strict.
But in general this is how it is used.
Sam
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
