Re: [PATCH] usbnet: increase bulk message timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 26, 2018 at 04:02:48PM +0300, Nikita Yushchenko wrote:
> Timeout of 1ms is too low for case when device operates in Full Speed
> mode. This causes most incoming frames to be lost.
> 
> Since timeout is only used to get out of polling loop in case of no
> response from hardware, increasing it should be safe for all platforms.
> 
> Signed-off-by: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx>
> Tested-By: Andrew Lunn <andrew@xxxxxxx>
> ---

Applied, thanks.

The patch is whitespace damaged, I fixed this up manually this time.

Sascha

>  drivers/net/usb/usbnet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 33d900b70..60e67ff1a 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -125,7 +125,7 @@ static int usbnet_recv(struct eth_device *edev)
>   	len = dev->rx_urb_size;
>  -	ret = usb_bulk_msg(dev->udev, dev->in, rx_buf, len, &alen, 1);
> +	ret = usb_bulk_msg(dev->udev, dev->in, rx_buf, len, &alen, 100);
>  	if (ret)
>  		return ret;
>  -- 2.11.0
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux