Re: [RFC] commands: i2c_write: enable raw write to address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Antony,

On Thu, Feb 08, 2018 at 10:48:56AM +0300, Antony Pavlov wrote:
> Sometimes for communication with a simple I2C devices
> (e.g. PCF8574 or TM1650) it's necessary to send only
> one data byte into the I2C device.
> Current i2c_write command makes this impossible because
> you can't just pass 'device address' and 'register number'
> (or 'device address' and 'one data byte') to the command.
> You always have to pass all three parameters:
> 'device address', 'register number' and 'data'.
> 
> This commit fixes the problem.
> 
> Sample usage:
> 
>   barebox@barebox sandbox:/ i2c_write -a 0x24 0x01
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@xxxxxxxxx>
> ---
>  commands/i2c.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Looks good to me.

I applied this one despite the [RFC] tag. If for some reason you want to
resend this, feel free to do so, but otherwise consider this applied.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux