Hi Sam, Am 30.10.2017 um 17:51 schrieb Sam Ravnborg: > Hi enrico > > On Mon, Oct 30, 2017 at 11:34:21AM +0100, Enrico Jorns wrote: >> Help did not point out that -r option requires n arguments and did not >> mention support for removing variables in help text. >> >> Signed-off-by: Enrico Jorns <ejo@xxxxxxxxxxxxxx> >> --- > ... > >> -BAREBOX_CMD_HELP_OPT("-r", "remove non volatile variables") >> -BAREBOX_CMD_HELP_OPT("-s", "Save NV variables") >> +BAREBOX_CMD_HELP_OPT("-r VAR1 ...", "remove non volatile variable(s)") >> +BAREBOX_CMD_HELP_OPT("-s\t", "save NV variables") > > It looks inconsistent that we in one line uses "non volatile" and the next line uses "NV". > I know it was like this before but since touching this line consider changing this > detail too. yes, this is a good point. Indeed it looks a bit inconsistent and should be touched by this series, too. I will turn a new round. Best regards, Enrico -- Pengutronix e.K. | Enrico Jörns | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5080 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox