Hi enrico On Mon, Oct 30, 2017 at 11:34:21AM +0100, Enrico Jorns wrote: > Help did not point out that -r option requires n arguments and did not > mention support for removing variables in help text. > > Signed-off-by: Enrico Jorns <ejo@xxxxxxxxxxxxxx> > --- ... > -BAREBOX_CMD_HELP_OPT("-r", "remove non volatile variables") > -BAREBOX_CMD_HELP_OPT("-s", "Save NV variables") > +BAREBOX_CMD_HELP_OPT("-r VAR1 ...", "remove non volatile variable(s)") > +BAREBOX_CMD_HELP_OPT("-s\t", "save NV variables") It looks inconsistent that we in one line uses "non volatile" and the next line uses "NV". I know it was like this before but since touching this line consider changing this detail too. I skimmed the other pacthes - looked good to me. Sam _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox