Hi, Ian Abbott <abbotti@xxxxxxxxx> writes: > Hi, > > I'm not using Arria-10, but noticed a possible bug in the > arria10_init_emac() function in > "arch/arm/mach-socfpga/arria10-generic.c". The code reads the > ARRIA10_SYSMGR_FPGAINTF_EN_3 register into a variable, modifies the > variable value, but doesn't write it back to the register. Thanks for catching that. I will send a patch for removing the whole read-modify operation, as it doesn't do anything now anyway and half of the bits aren't even mentioned in the datasheet. Best regards, Steffen -- Pengutronix e.K. | Steffen Trumtrar | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
